feat: Argument to set width for diagnostic cli outputs #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Apr 5, 2024
rvagg
requested changes
Apr 5, 2024
There was a problem hiding this comment.
Very nice, we've got a mini args parser growing here, next addition to the cli will probably either consolidate that or just add a proper args parser but this works nicely.
The remaining item here is updating the usage() function output to add [--width <chars>] to each of the 3 2diag commands.
Co-authored-by: Rod Vagg <[email protected]>
rvagg
approved these changes
Apr 5, 2024
|
thanks for the contribution, semver-minor release coming up |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
## [4.2.0](v4.1.4...v4.2.0) (2024-04-05) ### Features * cli argument to set width of diagnostic output ([#118](#118)) ([4891cb8](4891cb8))
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an argument to the cli set diagnostic width for cli
closes #116
Not exactly comfortable with the manual arg parsing and trying to catch incorrect cli usage but this seems to catch all kinds of weird/wrong inputs I could think of